Grant Henke has posted comments on this change. Change subject: [java] Gradle test task improvements ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7782/1//COMMIT_MSG Commit Message: > Trailing whitespace. Done PS1, Line 11: d: Ifb660b15423b68c299518b7ba54a15135972a007 : > Surefire doesn't do this in Maven (at least not within a module; there's a The root pom.xml sets reuseForks=false which means each test class executes in its own JVM process according to documentation here: http://maven.apache.org/surefire/maven-failsafe-plugin/examples/fork-options-and-parallel-execution.html Without this change many tests fail with "cannot re-acquire authentication token after 5 attempts". Removing reuseForks=false from the pom also causes similar errors. That said, perhaps their is an issue with acquiring tokens in a shared jvm that should be looked at. http://gerrit.cloudera.org:8080/#/c/7782/1/java/gradle/tests.gradle File java/gradle/tests.gradle: Line 39: // Set a few system properties. > Should we also set -Xmx1900m? I see that in Maven's testArgLine property. I saw that but had no failures as a result of memory issues. So I figured there was no reason to add it. We can always add it if we see issues. -- To view, visit http://gerrit.cloudera.org:8080/7782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
