Andrew Wong has posted comments on this change. Change subject: open FS layout in presence of disk failure ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/1/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: PS1, Line 592: uid_by_root_.swap(uuid_by_root); : : // From this point onwards, the above in-memory maps must be consistent with : // the main path set. : : // Initialize the 'fullness' status of the data directories. : for (const auto& dd : data_dirs_) { : uint16_t uuid_idx; : CHECK(FindUuidIndexByDataDir(dd.get(), &uuid_idx)); : if (ContainsKey(failed_data_dirs_, uuid_idx)) { : continue; : } : Status refresh_status = dd->RefreshIsFull(DataDir::RefreshMode::ALWAYS); : if (PREDICT_FALSE(!refresh_status.ok())) { : if (refresh_status.IsDiskFailure()) { : MarkDataDirFailed(uuid_idx, refresh_status.ToString()); : continue; : } : return refresh_status; : } : } re: why is this here and not higher up, yes this is here because MarkDataDirFailed needs the above to work. -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2a1c824526ed52a6b90ddfbc735cecc4c491118 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
