Mike Percy has posted comments on this change. Change subject: open FS layout in presence of disk failure ......................................................................
Patch Set 3: (6 comments) I'm still looking through this patch but so far I only have nits http://gerrit.cloudera.org:8080/#/c/7784/3//COMMIT_MSG Commit Message: PS3, Line 15: all s/all// PS3, Line 15: failsto fails to http://gerrit.cloudera.org:8080/#/c/7784/3/src/kudu/fs/block_manager_util.h File src/kudu/fs/block_manager_util.h: PS3, Line 57: not OK() 1. Why not just return an error? 2. If we really want to return OK, be a little more explicit: "... or, in the case of disk failure, returns OK but will set health_status_ to a non-OK value." PS3, Line 88: Status nit: const Status& ? http://gerrit.cloudera.org:8080/#/c/7784/3/src/kudu/fs/data_dirs.h File src/kudu/fs/data_dirs.h: PS3, Line 53: typedef std::pair<std::string, Status> CanonicalizedRoot; I think it would be easier to understand the code that uses this if it was renamed and made a struct: struct CanonicalizedRootAndStatus { std::string path; Status status; }; http://gerrit.cloudera.org:8080/#/c/7784/3/src/kudu/fs/fs_manager.h File src/kudu/fs/fs_manager.h: PS3, Line 302: Returned values This comment is a bit confusing. I think it would make more sense to say it like: Canonicalized forms of the root directories. Canonicalized during Init() with ordering maintained. -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2a1c824526ed52a6b90ddfbc735cecc4c491118 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
