Alexey Serbin has posted comments on this change. Change subject: open FS layout in presence of disk failure ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7784/5/src/kudu/fs/block_manager_util.cc File src/kudu/fs/block_manager_util.cc: PS5, Line 68: ; nit: this is not needed, right? Usually those macros are used as RETURN_NOT_OK_FAIL_INSTANCE_PREPEND(...); so the semicolon is added at the call site. http://gerrit.cloudera.org:8080/#/c/7784/5/src/kudu/fs/data_dirs-test.cc File src/kudu/fs/data_dirs-test.cc: PS5, Line 244: Status s = dd_manager_->MarkDataDirFailed(kNumDirs - 1); : ASSERT_STR_CONTAINS(s.ToString(), "All data dirs have failed"); As I see the call to CreateDataDirGroup() is removed. Is that correct? I mean, I would expect to see an attempt to do something with the object after marking all directories as failed (that looks like just a preparation for some meaningful action). PS5, Line 363: void OpenDataDirManager() { : ASSERT_OK(DataDirManager::OpenExistingForTests(env_, test_roots_, : DataDirManagerOptions(), &dd_manager_)); : } nit: consider making this method returning Status and then using ASSERT_OK() -- that way it would be more easier to find the place where it fails, if it does so. -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2a1c824526ed52a6b90ddfbc735cecc4c491118 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
