Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7784 to look at the new patch set (#6). Change subject: open FS layout in presence of disk failure ...................................................................... open FS layout in presence of disk failure Currently, if a Kudu server starts up with a failed disk, the server will crash. There are a number of reasons for this, but the pressing one is that the path instance files may not be readable, meaning the directories' UUIDs may not be available. This patch changes this by introducing an "unhealthy" instance in-memory for each instance that fails to lock, load, canonicalize, etc. Such instances are ignored when it comes to checking the integrity of the FS layout, and are simply marked failed by the directory manager. Testing is done in data_dirs-test, log_block_manager-test, and fs_manager-test to ensure failed directories do not impede the managers' startups. Change-Id: Ib2a1c824526ed52a6b90ddfbc735cecc4c491118 --- M src/kudu/fs/block_manager-stress-test.cc M src/kudu/fs/block_manager-test.cc M src/kudu/fs/block_manager_util-test.cc M src/kudu/fs/block_manager_util.cc M src/kudu/fs/block_manager_util.h M src/kudu/fs/data_dirs-test.cc M src/kudu/fs/data_dirs.cc M src/kudu/fs/data_dirs.h M src/kudu/fs/fs_manager-test.cc M src/kudu/fs/fs_manager.cc M src/kudu/fs/fs_manager.h M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc 13 files changed, 645 insertions(+), 173 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/7784/6 -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib2a1c824526ed52a6b90ddfbc735cecc4c491118 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot