Alexey Serbin has posted comments on this change. Change subject: catalog_manager: don't log deleted tables/tablets at startup ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7826/2//COMMIT_MSG Commit Message: PS2, Line 14: overriden nit: overridden http://gerrit.cloudera.org:8080/#/c/7826/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS2, Line 359: VLOG(2) interesting: for tables the debug log level is 1. Is this intentional to have debug log level 2 for tablets? PS2, Line 2616: WARNING Maybe, it's worth set to up ERROR since this is an error condition and the control flow goes out of this function? PS2, Line 2951: ... nit: drop the ellipsis? PS2, Line 2947: if (delay_millis <= 0) { : LOG(WARNING) << "Request timed out: " << description(); : MarkFailed(); : } else { : LOG(INFO) << Substitute("Scheduling retry of $0 with a delay of $1 ms (attempt = $2)...", : description(), delay_millis, attempt_); : master_->messenger()->ScheduleOnReactor( : boost::bind(&RetryingTSRpcTask::RunDelayedTask, this, _1), : MonoDelta::FromMilliseconds(delay_millis)); : return true; : } : return false; nit: while you are at it, consider removing the extra-scope for better readability: if (delay_millis <=0) { ... return false; } ... return true; -- To view, visit http://gerrit.cloudera.org:8080/7826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I557ebfe9d3ce1663e7f7c189f0087bdd29a09306 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
