Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7826 to look at the new patch set (#3). Change subject: catalog_manager: don't log deleted tables/tablets at startup ...................................................................... catalog_manager: don't log deleted tables/tablets at startup On long-lived clusters this list can get quite long. While I was in the area, I made some other cosmetic improvements: - Applying strings::Substitute() to perforated LOG statements. - Replacing 'OVERRIDE' with 'override'. - Removing 'virtual' from overridden methods. - Removing unnecessary std:: prefixes. - Adding virtual destructors to {Table,Tablet}Visitor. - A few other miscellaneous tweaks. The new virtual destructors caused sys_catalog-test to fail in a bizarre way: the catalog manager ran ~TabletLoader defined in sys_catalog-test.cc rather than the implicit one from catalog_manager.cc. I fixed this by renaming the sys_catalog-test {Table,Tablet}Loader classes; not quite sure why there was no collision at link-time in the first place. Change-Id: I557ebfe9d3ce1663e7f7c189f0087bdd29a09306 --- M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog-test.cc M src/kudu/master/sys_catalog.h 3 files changed, 204 insertions(+), 219 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/7826/3 -- To view, visit http://gerrit.cloudera.org:8080/7826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I557ebfe9d3ce1663e7f7c189f0087bdd29a09306 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>