Alexey Serbin has posted comments on this change. Change subject: [tests] fix flakes in delete_table-itest ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7972/3/src/kudu/integration-tests/delete_table-itest.cc File src/kudu/integration-tests/delete_table-itest.cc: PS3, Line 1216: : : > Instead of adding the extra functions, could we do this in less by just wra I think that's a good idea. I thought about using ASSERT_EVENTUALLY(), but I was concerned with not spotting some other transitional issues (like if AddServer/RemoveServer returning something else but IllegalState()). But after you addressed my concerns for the similar situations in tablet_copy-itest, I think using ASSERT_EVENTUALLY() is good enough. Let me adopt this. -- To view, visit http://gerrit.cloudera.org:8080/7972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dda40ae1054becaf25963a6d301ecaed5a926f9 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
