Alexey Serbin has posted comments on this change. Change subject: [tests] fix flakes in delete_table-itest ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7972/3/src/kudu/integration-tests/delete_table-itest.cc File src/kudu/integration-tests/delete_table-itest.cc: PS3, Line 1216: : : > Instead of adding the extra functions, could we do this in less by just wra And another catch is: the server to remove should be different from the server just added, and the logic to find appropriate server is different for different operations. So, the result code would not be that simple at all. :) But anyway, I'm going to use ASSERT_EVENTUALLY() to have blanket-handling for any type of errors appear during the process. -- To view, visit http://gerrit.cloudera.org:8080/7972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dda40ae1054becaf25963a6d301ecaed5a926f9 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes