Hao Hao has posted comments on this change. Change subject: Add a simple benchmark to create 1M blocks and reopen LBM ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8006/1/src/kudu/fs/block_id.h File src/kudu/fs/block_id.h: Line 28: #include "kudu/gutil/hash/hash.h" Remove? http://gerrit.cloudera.org:8080/#/c/8006/1/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: Line 784: FLAGS_block_manager_preflush_control = "never"; You set the flag to be 'never' to try to avoid the 'stable page writes' issue we talked about on slack? If so, can you add a comment here? -- To view, visit http://gerrit.cloudera.org:8080/8006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cc3547db7d8389c4e89ff9d4d3043b5f2fbe878 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
