Adar Dembo has posted comments on this change. Change subject: Add a simple benchmark to create 1M blocks and reopen LBM ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8006/1/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: Line 793: ASSERT_OK_FAST(block->Finalize()); By finalizing each block, you'll fill up one container at a time, which maximizes the number of blocks relative to the number of containers on disk. Don't you want something more representative of a Kudu workflow, with multiple outstanding transactions, each writing some group of blocks at a time? That'd be equivalent to several concurrent flushes, and is similar to what block_manager-stress-test does. Line 799: LOG_TIMING(INFO, "reopening block manager") { Maybe do the timing yourself and print out the average? -- To view, visit http://gerrit.cloudera.org:8080/8006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cc3547db7d8389c4e89ff9d4d3043b5f2fbe878 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
