Dan Burkert has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files ......................................................................
Patch Set 1: I don't want to block merging this, but we might want to think about this is a bigger context. This is an issue in a lot of APIs, and the fact of the matter is the c++ stdlib is not equipped to deal with it. It may be time to bring in something like gsl for the Span type https://github.com/microsoft/gsl. -- To view, visit http://gerrit.cloudera.org:8080/8009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I228f26416b750c5a30ec6cc0763257c7d8b8d56f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: No
