Adar Dembo has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files ......................................................................
Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/pb_util.cc File src/kudu/util/pb_util.cc: Line 198: if (*offset + length > file_size) { > hm, actually upon further thought, do you think faststring seems out-of-pla OK. Instead, how about a short blurb in contributing.adoc that explains when to use faststring? -- To view, visit http://gerrit.cloudera.org:8080/8009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I228f26416b750c5a30ec6cc0763257c7d8b8d56f Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
