Hello Alexey Serbin, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8171
to review the following change.
Change subject: env_posix: add another failure case to Walk
......................................................................
env_posix: add another failure case to Walk
The manpage for fts_read has this to say about FTS_NS:
A file for which no stat(2) information was available. The con‐
tents of the fts_statp field are undefined. This is an error
return, and the fts_errno field will be set to indicate what
caused the error.
As such, we should treat it the same as FTS_ERR.
The new test fails without this change, which I found somewhat surprising;
I would have expected fts_open(2) to at least check for the existence of the
root directory, but apparently that's deferred to fts_read(2).
Change-Id: I16edaec169d074913768c95a16173ff105d7b6a1
---
M src/kudu/util/env-test.cc
M src/kudu/util/env_posix.cc
2 files changed, 38 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/8171/1
--
To view, visit http://gerrit.cloudera.org:8080/8171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16edaec169d074913768c95a16173ff105d7b6a1
Gerrit-Change-Number: 8171
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
