Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8171 )
Change subject: env_posix: add more failure cases to Walk ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8171/2/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc: http://gerrit.cloudera.org:8080/#/c/8171/2/src/kudu/util/env-test.cc@755 PS2, Line 755: execute nit: I think it's about read permission on directory as well -- the tree walk needs to know what is the contents of the directory to be able to descend further down the tree. At least, it fails with 0100 permission for the directory as well (i.e. having only the 'execute' bit). However, the current statement is correct as it is -- without the execute bit on directory the tree walk fails. :) -- To view, visit http://gerrit.cloudera.org:8080/8171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16edaec169d074913768c95a16173ff105d7b6a1 Gerrit-Change-Number: 8171 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 29 Sep 2017 17:48:23 +0000 Gerrit-HasComments: Yes
