Hello David Ribeiro Alves, Andrew Wong (DEPRECATED: please use 
[email protected]),

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/8288

to review the following change.


Change subject: env_util: remove ScopedFileDeleter
......................................................................

env_util: remove ScopedFileDeleter

It's a holdover from before ScopedCleanup existed.

The intermingling of files and directories is a neat feature, but it's only
used in two places and isn't worth the complexity of a dedicated class.

Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
---
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tools/tool_action_pbc.cc
M src/kudu/util/env_util.cc
M src/kudu/util/env_util.h
M src/kudu/util/pb_util.cc
7 files changed, 64 insertions(+), 81 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/8288/1
--
To view, visit http://gerrit.cloudera.org:8080/8288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c
Gerrit-Change-Number: 8288
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong (DEPRECATED: please use [email protected]) 
<[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>

Reply via email to