Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8288 )
Change subject: env_util: remove ScopedFileDeleter ...................................................................... env_util: remove ScopedFileDeleter It's a holdover from before ScopedCleanup existed. The intermingling of files and directories is a neat feature, but it's only used in two places and isn't worth the complexity of a dedicated class. Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c Reviewed-on: http://gerrit.cloudera.org:8080/8288 Reviewed-by: Andrew Wong <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Adar Dembo <[email protected]> --- M src/kudu/fs/data_dirs.cc M src/kudu/fs/fs_manager.cc M src/kudu/fs/log_block_manager.cc M src/kudu/tools/tool_action_pbc.cc M src/kudu/util/env_util.cc M src/kudu/util/env_util.h M src/kudu/util/pb_util.cc 7 files changed, 65 insertions(+), 81 deletions(-) Approvals: Andrew Wong: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, approved Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/8288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I245fec4fc07caffad40b1bf1ba9b16839b08136c Gerrit-Change-Number: 8288 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
