Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 )
Change subject: WIP log block manager: return early if read-only ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8338/1/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/8338/1/src/kudu/fs/log_block_manager-test.cc@872 PS1, Line 872: // The first write will fail, as the container has been marked read-only. > In this case, the container is first been made available via Finalize(), an That seems hard to do: once a container is available, someone can grab it at any time, including while we're figuring out that, actually, it's messed up and should be read-only. Meaning, even if we did something like change SetReadOnly() to also make the container unavailable, there's no guarantee that it hasn't been seized by another thread. It'd probably be sufficient to doc this, because with full disk error handling this isn't an issue anymore, right? The container's data dir will fail, as will any tablets that could conceivably grab this container (i.e. those whose data dir group includes the container's data dir). -- To view, visit http://gerrit.cloudera.org:8080/8338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06412a36ed62fe1e3a2307a4a2e7a0a7e3d65702 Gerrit-Change-Number: 8338 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 19 Oct 2017 22:43:34 +0000 Gerrit-HasComments: Yes
