Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 )
Change subject: WIP log block manager: return early if read-only ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8338/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/8338/2/src/kudu/fs/log_block_manager.cc@1062 PS2, Line 1062: FinalizeBlock > I don't think this will change much. MakeContainerAvailable already _doesn' On second thought, maybe it's worth more consideration. Should the below bookkeeping not happen if it is read-only? -- To view, visit http://gerrit.cloudera.org:8080/8338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06412a36ed62fe1e3a2307a4a2e7a0a7e3d65702 Gerrit-Change-Number: 8338 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 20 Oct 2017 19:25:06 +0000 Gerrit-HasComments: Yes
