Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 )
Change subject: log block manager: return early if read-only ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/8338/4/src/kudu/fs/log_block_manager.h File src/kudu/fs/log_block_manager.h: http://gerrit.cloudera.org:8080/#/c/8338/4/src/kudu/fs/log_block_manager.h@112 PS4, Line 112: transac > Change it to transaction to be more specific? Done http://gerrit.cloudera.org:8080/#/c/8338/4/src/kudu/fs/log_block_manager.h@118 PS4, Line 118: above > Nit: since it's not in the immediate paragraph "above" maybe change to "afo changed to the "above commit", which is in the immediate above paragraph http://gerrit.cloudera.org:8080/#/c/8338/4/src/kudu/fs/log_block_manager.h@122 PS4, Line 122: pot > And also mention could corrupt the underlying container? Done http://gerrit.cloudera.org:8080/#/c/8338/4/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/8338/4/src/kudu/fs/log_block_manager.cc@1842 PS4, Line 1842: HANDLE_DISK_FAILURE(lb->container()->read_only_status(), > Am I correct in my understanding that this will fail the data directory syn Yes that will be the case. With the proper locking in error handling (not yet pushed), these wrapped calls _should_ ensure that error handling has completed upon return. -- To view, visit http://gerrit.cloudera.org:8080/8338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06412a36ed62fe1e3a2307a4a2e7a0a7e3d65702 Gerrit-Change-Number: 8338 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Sat, 21 Oct 2017 00:12:06 +0000 Gerrit-HasComments: Yes
