Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 )
Change subject: log block manager: return early if read-only ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8338/3/src/kudu/fs/log_block_manager.h File src/kudu/fs/log_block_manager.h: http://gerrit.cloudera.org:8080/#/c/8338/3/src/kudu/fs/log_block_manager.h@104 PS3, Line 104: container This was actually more correct as 'block', I think, because 'available' here isn't referring to making a container available for another writer, but making the block available to readers. http://gerrit.cloudera.org:8080/#/c/8338/3/src/kudu/fs/log_block_manager.h@108 PS3, Line 108: // The current container-availability semantics enforce that a single container I'd reword this to downplay "container availabiliity" and instead to describe this in terms of the public API, drawing upon block finalization as the operation that allows a new entity to start writing to the container. http://gerrit.cloudera.org:8080/#/c/8338/3/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/8338/3/src/kudu/fs/log_block_manager.cc@1842 PS3, Line 1842: if (lb->container()->read_only()) { : return Status::IllegalState(Substitute("container $0 is read-only", : lb->container()->ToString())); : } Do we want to use the read_only_status_ here? -- To view, visit http://gerrit.cloudera.org:8080/8338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06412a36ed62fe1e3a2307a4a2e7a0a7e3d65702 Gerrit-Change-Number: 8338 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 20 Oct 2017 21:47:09 +0000 Gerrit-HasComments: Yes
