Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8393 )
Change subject: KUDU-2200: provide better diagnostics when connecting to a subset of masters ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/8393/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java: http://gerrit.cloudera.org:8080/#/c/8393/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java@108 PS1, Line 108: // One of the connections should have succeeded. : assertEquals(1, successes); > I chatted with Dan about this on Slack last week. His opinion was that, if Yah I'm just being kind of conservative. If the client always hard fails when the number of masters doesn't match, then it may make it difficult to reconfigure and add/drop masters. I admit it's something of a hypothetical concern, but I think this patch is going to get us most of the bang-for-buck as it is. http://gerrit.cloudera.org:8080/#/c/8393/1/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/8393/1/src/kudu/master/master.cc@344 PS1, Line 344: > leaders are also VOTERs. This is a bit of a forward-looking if statement th Woops, I actually looked up the enum values, but I think I confused Role with MemberType. http://gerrit.cloudera.org:8080/#/c/8393/2/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/8393/2/src/kudu/master/master.cc@352 PS2, Line 352: if (!peer.has_last_known_addr()) { Thanks. This same issue had actually tripped me up in the HMS work (getting the master addrs to add to the HMS entry), so I'm glad to have a general solution available. -- To view, visit http://gerrit.cloudera.org:8080/8393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52f903e1aa5ae6948ca1ba6d4d856c3c9dc73d56 Gerrit-Change-Number: 8393 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 31 Oct 2017 01:21:56 +0000 Gerrit-HasComments: Yes
