Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8393 )
Change subject: KUDU-2200: provide better diagnostics when connecting to a subset of masters ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8393/2/src/kudu/integration-tests/master_replication-itest.cc File src/kudu/integration-tests/master_replication-itest.cc: http://gerrit.cloudera.org:8080/#/c/8393/2/src/kudu/integration-tests/master_replication-itest.cc@308 PS2, Line 308: LOG(ERROR) << resp.DebugString(); > nit: is it crucial to output this, especially as an error? nope, that was accidentally left in http://gerrit.cloudera.org:8080/#/c/8393/2/src/kudu/integration-tests/master_replication-itest.cc@333 PS2, Line 333: // - 0, in the case that no master had elected itself yet : // - 1, in the case that one master had become leader by the time we connected. > Is it possible that leader re-election happens among masters just between c Given this test doesn't push any kind of stress workload, I think it would be very unlikely for the masters to randomly re-elect themselves. At least we have some other tests that make similar assertions that leadership is stable over short periods of time, assuming no extra load. http://gerrit.cloudera.org:8080/#/c/8393/2/src/kudu/integration-tests/master_replication-itest.cc@335 PS2, Line 335: LE > It seems it should be EXPECT_GE(). oops... duh -- To view, visit http://gerrit.cloudera.org:8080/8393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52f903e1aa5ae6948ca1ba6d4d856c3c9dc73d56 Gerrit-Change-Number: 8393 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 23:48:25 +0000 Gerrit-HasComments: Yes
