Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8440 )
Change subject: cfile_set: don't reset BloomFileReader on error ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8440/1//COMMIT_MSG Commit Message: PS1: Makes sense, but given the age of this "optimization", could you get a second opinion from Todd, who originally wrote it? http://gerrit.cloudera.org:8080/#/c/8440/1/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: http://gerrit.cloudera.org:8080/#/c/8440/1/src/kudu/tablet/cfile_set.cc@244 PS1, Line 244: if (bloom_reader_ && FLAGS_consult_bloom_filters) { Under what circumstances is bloom_reader_ null now? Seems like any CFileSet would always have one created, no? -- To view, visit http://gerrit.cloudera.org:8080/8440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7435da448a1a33ca5216923311ab920f7a859806 Gerrit-Change-Number: 8440 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 01 Nov 2017 20:02:21 +0000 Gerrit-HasComments: Yes
