Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8440 )
Change subject: cfile_set: don't reset BloomFileReader on error ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8440/1//COMMIT_MSG Commit Message: PS1: > Makes sense, but given the age of this "optimization", could you get a seco looks fine to me (Andrew chatted about it with me ahead of writing the patch) http://gerrit.cloudera.org:8080/#/c/8440/1/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: http://gerrit.cloudera.org:8080/#/c/8440/1/src/kudu/tablet/cfile_set.cc@258 PS1, Line 258: LOG(WARNING) << "Unable to query bloom: " << s.ToString(); in the case that we somehow have a corrupt bloom file, maybe this warning would start flooding the logs? I think we'd be better off if we included a few more things in the log message (eg the block id) and also used a KLOG_EVERY_N_SECS macro to ensure it doesn't turn into a flood -- To view, visit http://gerrit.cloudera.org:8080/8440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7435da448a1a33ca5216923311ab920f7a859806 Gerrit-Change-Number: 8440 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 03 Nov 2017 00:06:25 +0000 Gerrit-HasComments: Yes
