Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8533 )
Change subject: Add initial internal INT128/__int128 support ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8533/3/src/kudu/util/int128.h File src/kudu/util/int128.h: http://gerrit.cloudera.org:8080/#/c/8533/3/src/kudu/util/int128.h@21 PS3, Line 21: #ifndef KUDU_UTIL_INT128_H Prefer '#pragma once' for new headers. -- To view, visit http://gerrit.cloudera.org:8080/8533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36458a54dfdd28be03f80d83688c0d658944e8e1 Gerrit-Change-Number: 8533 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 14 Nov 2017 19:22:58 +0000 Gerrit-HasComments: Yes