Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8533 )
Change subject: Add initial internal INT128/__int128 support ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/8533/7/src/kudu/util/int128-test.cc File src/kudu/util/int128-test.cc: http://gerrit.cloudera.org:8080/#/c/8533/7/src/kudu/util/int128-test.cc@29 PS7, Line 29: int128_t INTEGERS[] = {0, -1, 1, -1234567890}; maybe, it's also worth to verify how INT128_MIN is printed out. http://gerrit.cloudera.org:8080/#/c/8533/7/src/kudu/util/int128-test.cc@31 PS7, Line 31: sizeof(INTEGERS) / sizeof(INTEGERS[0]) nit: consider using 'arraysize' macro here http://gerrit.cloudera.org:8080/#/c/8533/7/src/kudu/util/int128-test.cc@32 PS7, Line 32: stringstream nit: ostringstream http://gerrit.cloudera.org:8080/#/c/8533/7/src/kudu/util/int128-test.cc@34 PS7, Line 34: (ss.str(), nit: expected value comes first http://gerrit.cloudera.org:8080/#/c/8533/7/src/kudu/util/int128-test.cc@39 PS7, Line 39: {0, 1, 1234567890}; mind adding INT128_MAX * 2 into the list (sure, it should be properly casted, etc.)? Also, it's interesting what static_cast<uint128_t>(-1) would look like when it's printed out. -- To view, visit http://gerrit.cloudera.org:8080/8533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36458a54dfdd28be03f80d83688c0d658944e8e1 Gerrit-Change-Number: 8533 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 15 Nov 2017 19:12:09 +0000 Gerrit-HasComments: Yes
