Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8533 )
Change subject: Add initial internal INT128/__int128 support ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/8533/10/src/kudu/gutil/strings/numbers-test.cc File src/kudu/gutil/strings/numbers-test.cc: http://gerrit.cloudera.org:8080/#/c/8533/10/src/kudu/gutil/strings/numbers-test.cc@29 PS10, Line 29: std::string > nit: you could use Done http://gerrit.cloudera.org:8080/#/c/8533/10/src/kudu/gutil/strings/numbers-test.cc@30 PS10, Line 30: ASSERT_EQ("170141183460469231731687303715884105727", maxStr); > nit: expected value comes first. Done http://gerrit.cloudera.org:8080/#/c/8533/10/src/kudu/gutil/strings/numbers.cc File src/kudu/gutil/strings/numbers.cc: http://gerrit.cloudera.org:8080/#/c/8533/10/src/kudu/gutil/strings/numbers.cc@1077 PS10, Line 1077: static const unsigned __int128 TWENTY_DIGITS = > static const ... ? Done http://gerrit.cloudera.org:8080/#/c/8533/10/src/kudu/util/int128-test.cc File src/kudu/util/int128-test.cc: http://gerrit.cloudera.org:8080/#/c/8533/10/src/kudu/util/int128-test.cc@54 PS10, Line 54: ASSERT_ > nit: it's not important, but if the expected value comes first, then it's e Done -- To view, visit http://gerrit.cloudera.org:8080/8533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36458a54dfdd28be03f80d83688c0d658944e8e1 Gerrit-Change-Number: 8533 Gerrit-PatchSet: 11 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Thu, 16 Nov 2017 05:39:28 +0000 Gerrit-HasComments: Yes
