Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8533 )
Change subject: Add initial internal INT128/__int128 support ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/8533/15/src/kudu/util/int128-test.cc File src/kudu/util/int128-test.cc: http://gerrit.cloudera.org:8080/#/c/8533/15/src/kudu/util/int128-test.cc@20 PS15, Line 20: #include <stdint.h> use <cstdint> to be consistent with the <cstddef> already here. Pretty sure IWYU allows either. http://gerrit.cloudera.org:8080/#/c/8533/15/src/kudu/util/int128.h File src/kudu/util/int128.h: http://gerrit.cloudera.org:8080/#/c/8533/15/src/kudu/util/int128.h@43 PS15, Line 43: std::ostream& operator<<(std::ostream& os, const __int128& val); You might consider defining this with int128_t instead of __int128, but feel free to ignore if there's a good reason not to. -- To view, visit http://gerrit.cloudera.org:8080/8533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36458a54dfdd28be03f80d83688c0d658944e8e1 Gerrit-Change-Number: 8533 Gerrit-PatchSet: 15 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Thu, 30 Nov 2017 18:37:40 +0000 Gerrit-HasComments: Yes
