Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8551 )
Change subject: [spark] Remove AsyncClient in KuduContext ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8551/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8551/1//COMMIT_MSG@7 PS1, Line 7: [spark] Remove AsyncClient in KuduContext > wouldn't this be a breaking change? I see we have annotated KuduContext as I suggested the removal, since it's not used internally, and both this API and the AsyncKuduClient class itself are marked unstable. Having two clients be available means that timestamp propagation doesn't work correctly. http://gerrit.cloudera.org:8080/#/c/8551/1//COMMIT_MSG@9 PS1, Line 9: aviod avoid -- To view, visit http://gerrit.cloudera.org:8080/8551 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica8745d8503a35e17a632d0a0cde5738915f00fb Gerrit-Change-Number: 8551 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 17 Nov 2017 00:44:53 +0000 Gerrit-HasComments: Yes
