Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8551 )
Change subject: [spark] Remove AsyncClient in KuduContext ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8551/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8551/1//COMMIT_MSG@7 PS1, Line 7: [spark] Remove AsyncClient in KuduContext > Can we not just update both the sync and async clients? And propagate the m Now we only update sync client for timestamp propagation and I don't see in this way it would affect the correctness? I thought the concern is to avoid misuse in future? (Maybe I have missed something) If we are worrying about compatibility, I remember Dan suggested another way is to redefine AsyncClient so that they are sharing the same client instance underneath. -- To view, visit http://gerrit.cloudera.org:8080/8551 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica8745d8503a35e17a632d0a0cde5738915f00fb Gerrit-Change-Number: 8551 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 17 Nov 2017 22:17:23 +0000 Gerrit-HasComments: Yes
