Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 )
Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert ...................................................................... Patch Set 2: > > Would it make more sense to just call it GetServerCertFromChain(), > > instead of GetTopofChainX509() ? > > As I understand, those wrapper functions could be used to work with > client-side certs, right? If so, then I don't think > GetServerCertFromChain() is the best choice here. Yes, you're right. The 'Cert' class is generic and not specific to server certs. I'll leave the name as it is then. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/8595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e3f913259ec4c855ff211726fa6ecea94d328e7 Gerrit-Change-Number: 8595 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Mon, 20 Nov 2017 18:05:25 +0000 Gerrit-HasComments: No