Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 )
Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8595/2/src/kudu/security/test/test_certs.cc File src/kudu/security/test/test_certs.cc: http://gerrit.cloudera.org:8080/#/c/8595/2/src/kudu/security/test/test_certs.cc@506 PS2, Line 506: CreateTestSSLCertSignedByChain Which cert do we want do use, actually? Could we drop the old one? Also, how do we know that GetTopOfChainX509() returns the expected cert, not that GetEndOfChainX509() would return? Does it make sense to add some verification on the parameters of the cert returned by GetTopOfChainX509() ? -- To view, visit http://gerrit.cloudera.org:8080/8595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e3f913259ec4c855ff211726fa6ecea94d328e7 Gerrit-Change-Number: 8595 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Mon, 20 Nov 2017 18:07:24 +0000 Gerrit-HasComments: Yes
