Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8868 )
Change subject: WIP: consensus: Fix NON_VOTER ack-counting bug ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/8868/1/src/kudu/consensus/consensus-test-util.h File src/kudu/consensus/consensus-test-util.h: http://gerrit.cloudera.org:8080/#/c/8868/1/src/kudu/consensus/consensus-test-util.h@83 PS1, Line 83: peer_pb.set_member_type(RaftPeerPB::VOTER); nit: maybe, more this into a separate changelist. http://gerrit.cloudera.org:8080/#/c/8868/1/src/kudu/consensus/consensus_queue.h File src/kudu/consensus/consensus_queue.h: http://gerrit.cloudera.org:8080/#/c/8868/1/src/kudu/consensus/consensus_queue.h@139 PS1, Line 139: const std::string const std::string& ? http://gerrit.cloudera.org:8080/#/c/8868/1/src/kudu/consensus/consensus_queue.h@509 PS1, Line 509: void AdvanceQueueWatermark(const char* type, Please add a note into the inline doc describing the 'replica_types' parameter. http://gerrit.cloudera.org:8080/#/c/8868/1/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/8868/1/src/kudu/consensus/consensus_queue.cc@228 PS1, Line 228: CHECK(peer_pb.has_member_type()) << SecureShortDebugString(peer_pb); nit: maybe, it's worth move this and related changes into a separate changelist? That way it could be easier to track independent changes (if they are really independent). -- To view, visit http://gerrit.cloudera.org:8080/8868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13143e9bb4b76af3fd6dada28fcec05b27d24476 Gerrit-Change-Number: 8868 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 19 Dec 2017 01:28:15 +0000 Gerrit-HasComments: Yes
