Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8868 )
Change subject: consensus: Fix NON_VOTER ack-counting bug ...................................................................... Patch Set 5: (4 comments) just a couple of nits http://gerrit.cloudera.org:8080/#/c/8868/5/src/kudu/consensus/consensus_queue-test.cc File src/kudu/consensus/consensus_queue-test.cc: http://gerrit.cloudera.org:8080/#/c/8868/5/src/kudu/consensus/consensus_queue-test.cc@499 PS5, Line 499: 4 2? http://gerrit.cloudera.org:8080/#/c/8868/5/src/kudu/consensus/consensus_queue-test.cc@503 PS5, Line 503: and the NON_VOTER ack it, but not : // the 2nd voter. nit: it seems this is a bit out-of-date, since non-voter ack is set in the code for item 3. http://gerrit.cloudera.org:8080/#/c/8868/5/src/kudu/consensus/consensus_queue.h File src/kudu/consensus/consensus_queue.h: http://gerrit.cloudera.org:8080/#/c/8868/5/src/kudu/consensus/consensus_queue.h@516 PS5, Line 516: can : // be 'can be' --> 'is' ? http://gerrit.cloudera.org:8080/#/c/8868/5/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/8868/5/src/kudu/consensus/consensus_queue.cc@272 PS5, Line 272: local_copy.set_member_type(RaftPeerPB::NON_VOTER); Could you add a comment to explain why the member type is set to NON_VOTER in this case? -- To view, visit http://gerrit.cloudera.org:8080/8868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13143e9bb4b76af3fd6dada28fcec05b27d24476 Gerrit-Change-Number: 8868 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Sat, 06 Jan 2018 03:21:01 +0000 Gerrit-HasComments: Yes
