Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 )
Change subject: KUDU-1927: no half-baked responses on ConnectoToMaster ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/9052/5/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/9052/5/src/kudu/master/master_service.cc@477 PS5, Line 477: if (cert_authority->is_initialized()) { > It seems to be true, and it seems the original version has never aborted be well, it adds complexity to the MasterCertAuthority class, right? Also it seems generally useful to say that the response to this method indicates whether the master is a _ready_ master, not just a master according to Consensus. The cert authority issue here is one particular result of a non-ready master reporting itself as ready, but in the future seems plausible there would be others, no? http://gerrit.cloudera.org:8080/#/c/9052/5/src/kudu/master/master_service.cc@507 PS5, Line 507: (!has_cert || (!has_authn_token && needs_authn_token))) { In KUDU-1927 Adar wrote: > If !leader_status.ok() but Role() is LEADER, it's indeed a sign that the > consensus state machine has elected this master as leader, but the leader is > still becoming active and setting up in-memory state. In that case, we should > enforce that resp->role() is not set to LEADER (i.e. just overwrite it with > UNKNOWN_ROLE, FOLLOWER, or whatever). which is what I'm suggesting here. -- To view, visit http://gerrit.cloudera.org:8080/9052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c906863f5f0e1995041281b122135e1b2cd3a4 Gerrit-Change-Number: 9052 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 25 Jan 2018 01:01:34 +0000 Gerrit-HasComments: Yes
