Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 )
Change subject: KUDU-1927: no half-baked responses on ConnectoToMaster ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/9052/5/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/9052/5/src/kudu/master/master_service.cc@477 PS5, Line 477: if (cert_authority->is_initialized()) { > well, it adds complexity to the MasterCertAuthority class, right? Yep, that adds additional boolean variable and is_initialized() method: basically, an explicit way to detect whether it's safe to call other methods of MasterCertAuthority without risking abort(). However, if we don't need that in any of the use cases, we can keep the original version. Yes, there might be more sub-components there with their own statuses. If we want to keep that under the blanket of l.leader_status(), all right then. http://gerrit.cloudera.org:8080/#/c/9052/5/src/kudu/master/master_service.cc@507 PS5, Line 507: (!has_cert || (!has_authn_token && needs_authn_token))) { > In KUDU-1927 Adar wrote: All right, but do we want to make sure we were able to issue an authn token as the response, if needed? In other words, is it be OK for a master to report itself as leader in the response if it failed to issue an authn token for the connecting client? -- To view, visit http://gerrit.cloudera.org:8080/9052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c906863f5f0e1995041281b122135e1b2cd3a4 Gerrit-Change-Number: 9052 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 25 Jan 2018 01:26:08 +0000 Gerrit-HasComments: Yes
