Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9510 )
Change subject: [tools] KUDU-2331: Allow move tool to work when uninvolved tserver is down ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9510/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9510/2//COMMIT_MSG@7 PS2, Line 7: [tools] KUDU-2331: Allow move tool to work when uninvolved tserver is down > Could you add a regression test for this? Done http://gerrit.cloudera.org:8080/#/c/9510/2/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/9510/2/src/kudu/tools/tool_action_tablet.cc@150 PS2, Line 150: // The return Status is ignored since a tserver that is not the destination > Would it be worth logging as a warning? Or would that be distracting and no Distracting and not useful. Plus it'll get displayed a bunch of times since ksck is run multiple time for one move. http://gerrit.cloudera.org:8080/#/c/9510/2/src/kudu/tools/tool_action_tablet.cc@154 PS2, Line 154: ksck.FetchInfoFromTabletServers(); > Wrapping this in ignore_result() is an idiomatic way to express that we don Done -- To view, visit http://gerrit.cloudera.org:8080/9510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1fc60233f4f50f478da7ccb104e37df3067400c Gerrit-Change-Number: 9510 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 07 Mar 2018 01:53:42 +0000 Gerrit-HasComments: Yes
