Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9510 )
Change subject: [tools] KUDU-2331: Allow move tool to work when uninvolved tserver is down ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9510/4/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/9510/4/src/kudu/tools/kudu-admin-test.cc@236 PS4, Line 236: // TODO(wdberkeley): Might be able to combine the following 3 tests into 1. Yes, agreed. I think you want a value-parameterized test, and use Combine() to build a cartesian product across test dimensions (where one dimension is a boolean for EnableKudu1097, and the other is a tri-state for "regular", "peer down", and "KUDU-2331". Then, within the (now combined) test, you can condition certain actions (like running a workload, or the right number of tservers) on the dimensions via GetParam(). -- To view, visit http://gerrit.cloudera.org:8080/9510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1fc60233f4f50f478da7ccb104e37df3067400c Gerrit-Change-Number: 9510 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 07 Mar 2018 18:38:25 +0000 Gerrit-HasComments: Yes
