Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9898 )
Change subject: Upgrade to LLVM/Clang 6.0.0 ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/9898/3/build-support/iwyu/mappings/llvm.imp File build-support/iwyu/mappings/llvm.imp: http://gerrit.cloudera.org:8080/#/c/9898/3/build-support/iwyu/mappings/llvm.imp@18 PS3, Line 18: # For some unknown reason IWYU wants to include this file with : # quotes instead of <>. Nit: indent this so it's more clear it applies to Attributes.h and not the entire array? -- To view, visit http://gerrit.cloudera.org:8080/9898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I137180f0b167872d903d855282607bac17f92a83 Gerrit-Change-Number: 9898 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 17 Apr 2018 23:36:23 +0000 Gerrit-HasComments: Yes
