Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9898 )
Change subject: Upgrade to LLVM/Clang 6.0.0 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9898/3/src/kudu/codegen/row_projector.cc File src/kudu/codegen/row_projector.cc: http://gerrit.cloudera.org:8080/#/c/9898/3/src/kudu/codegen/row_projector.cc@26 PS3, Line 26: #include <gflags/gflags_declare.h> > it seems both clang-tidy and IWYU are confused about whether LLVM is a syst oh, I figured it out... it's because the actual check is "llvm include order", and in the context of the LLVM project, LLVM is a project header, not a system header. will see if I can customize this out. -- To view, visit http://gerrit.cloudera.org:8080/9898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I137180f0b167872d903d855282607bac17f92a83 Gerrit-Change-Number: 9898 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 17 Apr 2018 23:52:49 +0000 Gerrit-HasComments: Yes
