Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10106 )
Change subject: Modify fix_includes.py for Kudu usage, add a wrapper ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/10106/2/build-support/iwyu.py File build-support/iwyu.py: http://gerrit.cloudera.org:8080/#/c/10106/2/build-support/iwyu.py@102 PS2, Line 102: "--pretty=format:" Isn't --name-only sufficient to yield a list of filenames? http://gerrit.cloudera.org:8080/#/c/10106/2/build-support/iwyu/fix_includes.py File build-support/iwyu/fix_includes.py: PS2: FWIW, I do think it'd be useful to rework this patch into a form that'd be palatable upstream, so that if we want to rev it when revving IWYU, it'll be either easier to apply the patch, or we won't need to patch it at all. http://gerrit.cloudera.org:8080/#/c/10106/2/build-support/iwyu/fix_includes.py@1507 PS2, Line 1507: """Given a file_line + file being edited, return best *_KIND value or None.""" Maybe detail here how the args affect the execution of the function? -- To view, visit http://gerrit.cloudera.org:8080/10106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c286271a39a0d825fb11e5610d8eb7e5b0729b9 Gerrit-Change-Number: 10106 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 19 Apr 2018 17:50:56 +0000 Gerrit-HasComments: Yes
