Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10106 )
Change subject: Modify fix_includes.py for Kudu usage, add a wrapper ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10106/3/build-support/iwyu.py File build-support/iwyu.py: http://gerrit.cloudera.org:8080/#/c/10106/3/build-support/iwyu.py@151 PS3, Line 151: muted_paths = [p for p in paths if _is_muted(p)] > oops, need to remove this and the above kwarg Done http://gerrit.cloudera.org:8080/#/c/10106/3/build-support/iwyu.py@170 PS3, Line 170: args.extend(_FIX_INCLUDES_STYLE_FLAGS) : fixer_flags, _ = iwyu.fix_includes.ParseArgs(args) : > oops, this is a mistaken indentation Done -- To view, visit http://gerrit.cloudera.org:8080/10106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c286271a39a0d825fb11e5610d8eb7e5b0729b9 Gerrit-Change-Number: 10106 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 20 Apr 2018 01:15:04 +0000 Gerrit-HasComments: Yes
