Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10169 )
Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/consensus/raft_consensus.cc@1561 PS1, Line 1561: LOG_WITH_PREFIX_UNLOCKED(INFO) << "voting based on last-logged opid " One idea here is to change the signature of this method so that instead of just taking in OpId last_logged_opid, it instead takes some simple struct like: struct TabletVotingState { optional<OpId> last_logged_op_id; TabletDataState data_state; }; and then you can modify this message to switch on the passed-in data state. -- To view, visit http://gerrit.cloudera.org:8080/10169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Gerrit-Change-Number: 10169 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 24 Apr 2018 16:21:12 +0000 Gerrit-HasComments: Yes
