Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10169 )
Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/consensus/raft_consensus.cc@1561 PS1, Line 1561: if (tablet_voting_state.data_state == tablet::TABLET_DATA_COPYING) { > I like Todd's suggestion here and I think it's a good one. From a quick gre Done http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/integration-tests/tablet_copy-itest.cc File src/kudu/integration-tests/tablet_copy-itest.cc: http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/integration-tests/tablet_copy-itest.cc@1328 PS1, Line 1328: // last-logged OpId from the tombstoned replica. > I don't think this test actually tests the change in this patch. Maybe we c I see. Thanks. I have manually validated the logging. It seems to work. Would you more likely recommend dropping this test or the alternative you said below? http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/integration-tests/tablet_copy-itest.cc@1385 PS1, Line 1385: ASSERT_GT(cur_mtime, initial_mtime); > Alternatively, we can use this test for this purpose and instead of Request I see. Very useful info. http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/tserver/tablet_service.cc@1006 PS1, Line 1006: } > I think it would be preferable to incorporate this into the code path in ra Done -- To view, visit http://gerrit.cloudera.org:8080/10169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6 Gerrit-Change-Number: 10169 Gerrit-PatchSet: 2 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 02 May 2018 18:45:45 +0000 Gerrit-HasComments: Yes
