Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10151 )
Change subject: [tools] ksck improvements [6/n]: Refactor printing ...................................................................... Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/10151/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10151/5//COMMIT_MSG@17 PS5, Line 17: - Removes the --consensus flag. ksck is far less useful without it and : it doesn't seem like having it brings any benefit. > I don't think we make guarantees on backwards compat for tools. Also, I don I think it's not worth separating that out if the separation would bring too much hustle and double-work. So, I'm fine with keeping it as is. http://gerrit.cloudera.org:8080/#/c/10151/5/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/10151/5/src/kudu/tools/ksck.h@404 PS5, Line 404: std::ostream* out = nullptr Is this still relevant? Maybe, pass it as a parameter only to the methods that output results of the ksck checks? http://gerrit.cloudera.org:8080/#/c/10151/5/src/kudu/tools/ksck.h@463 PS5, Line 463: As an alternative approach, what do you think about keeping the logic about printing the results in KsckResults class itself? http://gerrit.cloudera.org:8080/#/c/10151/5/src/kudu/tools/ksck.h@478 PS5, Line 478: nit: indent http://gerrit.cloudera.org:8080/#/c/10151/5/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10151/5/src/kudu/tools/ksck.cc@221 PS5, Line 221: lse { Can this method be called multiple times with the same results_ member? If yes, then maybe make sure results_.master_consensus_conflict is set to false in the beginning. http://gerrit.cloudera.org:8080/#/c/10151/5/src/kudu/tools/ksck.cc@222 PS5, Line 222: results_.master_consensus_con nit: maybe, drop this and use results_.master_consensus_conflict instead? -- To view, visit http://gerrit.cloudera.org:8080/10151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8de619996b6cd753e6a9c01b1b60810a873e609 Gerrit-Change-Number: 10151 Gerrit-PatchSet: 9 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Thu, 26 Apr 2018 18:48:38 +0000 Gerrit-HasComments: Yes
