Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10151 )
Change subject: [tools] ksck improvements [6/n]: Refactor printing ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/10151/5/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/10151/5/src/kudu/tools/ksck.h@404 PS5, Line 404: std::ostream* out = nullptr > Is this still relevant? Maybe, pass it as a parameter only to the methods We still use it internally for checksum stuff progress updates-- it's more work to get it out than this patch makes it look like. That's a good candidate for a follow-up though (I have some more planned for checksum-related stuff already). http://gerrit.cloudera.org:8080/#/c/10151/5/src/kudu/tools/ksck.h@463 PS5, Line 463: PrintResults > As an alternative approach, what do you think about keeping the logic about Done http://gerrit.cloudera.org:8080/#/c/10151/5/src/kudu/tools/ksck.h@478 PS5, Line 478: int t > nit: indent Done http://gerrit.cloudera.org:8080/#/c/10151/5/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10151/5/src/kudu/tools/ksck.cc@221 PS5, Line 221: Ksck::CheckMasterConsensus > Can this method be called multiple times with the same results_ member? If Done http://gerrit.cloudera.org:8080/#/c/10151/5/src/kudu/tools/ksck.cc@222 PS5, Line 222: bool missing_or_conflict = false; > nit: maybe, drop this and use results_.master_consensus_conflict instead? Done -- To view, visit http://gerrit.cloudera.org:8080/10151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8de619996b6cd753e6a9c01b1b60810a873e609 Gerrit-Change-Number: 10151 Gerrit-PatchSet: 5 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 27 Apr 2018 04:10:36 +0000 Gerrit-HasComments: Yes
