Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8279 )
Change subject: rpc: add experimental rpc_reuseport flag ...................................................................... Patch Set 3: (3 comments) > Patch Set 3: Verified-1 > > Build Failed > > http://jenkins.kudu.apache.org/job/kudu-gerrit/13233/ : FAILURE http://gerrit.cloudera.org:8080/#/c/8279/3/src/kudu/rpc/messenger.h File src/kudu/rpc/messenger.h: http://gerrit.cloudera.org:8080/#/c/8279/3/src/kudu/rpc/messenger.h@166 PS3, Line 166: SO_REUSEADDR > SO_REUSEPORT Done http://gerrit.cloudera.org:8080/#/c/8279/3/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/8279/3/src/kudu/rpc/messenger.cc@182 PS3, Line 182: reuseport_ = true; > reuseport_ needs a default value. Done http://gerrit.cloudera.org:8080/#/c/8279/3/src/kudu/util/net/socket.cc File src/kudu/util/net/socket.cc: http://gerrit.cloudera.org:8080/#/c/8279/3/src/kudu/util/net/socket.cc@263 PS3, Line 263: Status Socket::SetReusePort(bool flag) { > Seems like a fair amount of code could be consolidated if there was a singl Done -- To view, visit http://gerrit.cloudera.org:8080/8279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d8ce9faa646fa2be554f5cfdf8b6ed0c48b496e Gerrit-Change-Number: 8279 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 01 May 2018 19:32:10 +0000 Gerrit-HasComments: Yes
