Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8279 )
Change subject: rpc: add experimental rpc_reuseport flag ...................................................................... Patch Set 5: (6 comments) > Patch Set 4: > > (1 comment) Yep sorry, meant to circle back to this but didn't. I've updated the commit message on the latest revision with the error message so that it's indexed. http://gerrit.cloudera.org:8080/#/c/8279/4/src/kudu/util/net/socket.cc File src/kudu/util/net/socket.cc: http://gerrit.cloudera.org:8080/#/c/8279/4/src/kudu/util/net/socket.cc@166 PS4, Line 166: TCP_NODE > seems to be a typo: should be TCP_NODELAY Done http://gerrit.cloudera.org:8080/#/c/8279/4/src/kudu/util/net/socket.cc@176 PS4, Line 176: // TODO(unknown): Use TCP_NOPUSH for OSX if perf becomes an issue. > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/8279/4/src/kudu/util/net/socket.cc@241 PS4, Line 241: SO_REUSEADDR > typo: supposed to be SO_REUSEADDR? Done http://gerrit.cloudera.org:8080/#/c/8279/4/src/kudu/util/net/socket.cc@273 PS4, Line 273: if (::getsockname(fd_, reinterpret_cast<struct sockaddr*>(&sin), &len) == -1) { > warning: C-style casts are discouraged; use reinterpret_cast [google-readab Done http://gerrit.cloudera.org:8080/#/c/8279/4/src/kudu/util/net/socket.cc@285 PS4, Line 285: if (::getpeername(fd_, reinterpret_cast<struct sockaddr*>(&sin), &len) == -1) { > warning: C-style casts are discouraged; use reinterpret_cast [google-readab Done http://gerrit.cloudera.org:8080/#/c/8279/4/src/kudu/util/net/socket.cc@382 PS4, Line 382: if (::connect(fd_, reinterpret_cast<const struct sockaddr*>(&addr), sizeof(addr)) < 0) { > warning: C-style casts are discouraged; use reinterpret_cast [google-readab Done -- To view, visit http://gerrit.cloudera.org:8080/8279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d8ce9faa646fa2be554f5cfdf8b6ed0c48b496e Gerrit-Change-Number: 8279 Gerrit-PatchSet: 5 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 01 May 2018 22:09:22 +0000 Gerrit-HasComments: Yes
