Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10435 )
Change subject: KUDU-2427: retry more system calls on EINTR ...................................................................... Patch Set 3: (1 comment) Seem like we might be missing a few more: - Socket::Close - Log::IndexChunk::~IndexChunk - a few things in sysinfo.cc (open and close calls) - os-util.cc DisableCoreDumps - various close() and open() calls in subprocess.cc http://gerrit.cloudera.org:8080/#/c/10435/3/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/10435/3/src/kudu/util/env_posix.cc@300 PS3, Line 300: RETRY_ON_EINTR(err, ::close(fd_)); I think this might be tracked by KUDU-2151? worth adding it to the commit message and closing the jira when committed -- To view, visit http://gerrit.cloudera.org:8080/10435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cce03c4e1b2be32c1910382737526082fc99966 Gerrit-Change-Number: 10435 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 17 May 2018 17:47:00 +0000 Gerrit-HasComments: Yes
